fix: add limit to get cells #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
add-limit-to-get-cells
branch
5 times, most recently
from
8a31766
to
ed2b597
Compare
eval-exec
previously approved these changes
Aug 9, 2024
driftluo
force-pushed
the
add-limit-to-get-cells
branch
4 times, most recently
from
010db6c
to
033c182
Compare
chenyukang
reviewed
Aug 12, 2024
| # it may cause the physical machine to become unresponsive. | ||
| # We recommend a consumption limit of 2g, which is 400 as the limit, | ||
| # which is a safer approach | ||
| # request_limit = 400 |
There was a problem hiding this comment.
indexer_request_limit maybe a better name, as it's limiting the indexer request.
There was a problem hiding this comment.
This configuration item is under the indexer module. I don’t think it’s necessary to emphasize that it is the indexer request
driftluo
force-pushed
the
add-limit-to-get-cells
branch
2 times, most recently
from
5ce8c65
to
bb3c0c9
Compare
|
@driftluo Please rebase develop |
driftluo
force-pushed
the
add-limit-to-get-cells
branch
from
bb3c0c9
to
4eb59c5
Compare
eval-exec
approved these changes
Aug 13, 2024
driftluo
force-pushed
the
add-limit-to-get-cells
branch
from
4eb59c5
to
fb6309d
Compare
eval-exec
approved these changes
Aug 13, 2024
driftluo
force-pushed
the
add-limit-to-get-cells
branch
from
fb6309d
to
33e8ae8
Compare
Merged
via the queue into
nervosnetwork:develop
with commit Aug 13, 2024
3c827e9
29 of 31 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #4520 related serde-rs/json#635
A large number of data requests will consume more than 10x the memory when serialized in JSON, resulting in huge memory overhead and affecting the operation of the server
We recommend setting the memory usage limit at 2 GB, meaning only 200 MB of data can be requested at a time. The maximum cell data size is 500 KB, and 400 cells can be requested at one time.
In addition, we strongly recommend using this configuration #4529 to limit the upper limit of batch requests.
Check List
Tests
Release note